[webkit-reviews] review canceled: [Bug 179192] Use a String identifier consistently to identify Service Workers : [Attachment 325751] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has canceled  review:
Bug 179192: Use a String identifier consistently to identify Service Workers
https://bugs.webkit.org/show_bug.cgi?id=179192

Attachment 325751: Patch

https://bugs.webkit.org/attachment.cgi?id=325751&action=review




--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 325751
  --> https://bugs.webkit.org/attachment.cgi?id=325751
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325751&action=review

> Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:46
> +    const String& identifier() const { return
m_serviceWorkerThread->identifier(); }

Who calls this? If there's a way to get rid of callers to this, then we don't
need to worry.

If we truly do need to maintain this accessor, then we have two options:
1 - verify it is only used on a given thread and ASSERT it's only called on
that thread going forward
2 - make it return an isolated copy each time. :(