[webkit-reviews] review denied: [Bug 179100] Web Inspector: Styles Redesign: turn on CSS spreadsheet editor by default : [Attachment 325660] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 2 11:42:46 PDT 2017


Brian Burg <bburg at apple.com> has denied Nikita Vasilyev <nvasilyev at apple.com>'s
request for review:
Bug 179100: Web Inspector: Styles Redesign: turn on CSS spreadsheet editor by
default
https://bugs.webkit.org/show_bug.cgi?id=179100

Attachment 325660: Patch

https://bugs.webkit.org/attachment.cgi?id=325660&action=review




--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 325660
  --> https://bugs.webkit.org/attachment.cgi?id=325660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325660&action=review

The changes to remove old settings look fine. I want this in Experimental
though, so that we get more feedback and its clear we don't plan to maintain it
any more.

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:209
> +	   reloadInspectorButton.addEventListener("click", () => {
window.location.reload(); });

This should show up at the bottom of the settings pane. It looks weird putting
it inline. I think Experimental section has a reusable implementation already,
so you should be able to just remove this.


More information about the webkit-reviews mailing list