[webkit-reviews] review granted: [Bug 179151] [Service Workers] Add initial implementation for try Clear Registration / Clear Registration algorithms : [Attachment 325666] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 2 09:52:26 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179151: [Service Workers] Add initial implementation for try Clear
Registration / Clear Registration algorithms
https://bugs.webkit.org/show_bug.cgi?id=179151

Attachment 325666: Patch

https://bugs.webkit.org/attachment.cgi?id=325666&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 325666
  --> https://bugs.webkit.org/attachment.cgi?id=325666
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325666&action=review

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:78
>	   // If newestWorker is null, invoke Clear Registration algorithm
passing this registration as its argument.

Do we need that comment? It is pretty clear from the code already. Ditto below.


More information about the webkit-reviews mailing list