[webkit-reviews] review granted: [Bug 178996] Web Inspector: consolidate DOMTreeElement contextmenu items into submenus : [Attachment 325502] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178996: Web Inspector: consolidate DOMTreeElement contextmenu items into
submenus
https://bugs.webkit.org/show_bug.cgi?id=178996

Attachment 325502: Patch

https://bugs.webkit.org/attachment.cgi?id=325502&action=review




--- Comment #14 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 325502
  --> https://bugs.webkit.org/attachment.cgi?id=325502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325502&action=review

r=me. Its very hard to read the diff with all the line/indentation change.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:786
> +	   }, !isNonShadowEditable);

I think you will still want to disable this if !attribute. Otherwise I don't
know what this does. (For example if you right click on the tag name).

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:790
> +	   }, !attributeValue || !isNonShadowEditable);

Same idea here, you should be able to remove an attribute even if it doesn't
have an attributeValue. So probably if !attributeName instead of
!attributeValue.