[webkit-reviews] review granted: [Bug 179020] [Touch Bar Web API] Add support for menuitem tag : [Attachment 325482] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Aishwarya Nirmal
<anirmal at apple.com>'s request for review:
Bug 179020: [Touch Bar Web API] Add support for menuitem tag
https://bugs.webkit.org/show_bug.cgi?id=179020

Attachment 325482: Patch

https://bugs.webkit.org/attachment.cgi?id=325482&action=review




--- Comment #35 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 325482
  --> https://bugs.webkit.org/attachment.cgi?id=325482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325482&action=review

> Source/WebCore/ChangeLog:12
> +	   is set to false by default.	

Nits: There are two trailing spaces here.

> Source/WebCore/ChangeLog:13
> +

Please add some references to old HTML specifications like
https://www.w3.org/TR/2013/WD-html51-20130528/interactive-elements.html.

> Source/WebKit/ChangeLog:8
> +	   Adds in the MenuItemEnabled flag and default value. 

Nit: A trailing space at the end.

> Source/WebCore/html/HTMLMenuItemElement.idl:27
> +] interface HTMLMenuItemElement : HTMLElement {

So the idea is to implement more attributes of
https://www.w3.org/TR/2013/WD-html51-20130528/interactive-elements.html in the
future patches?