[webkit-reviews] review granted: [Bug 178926] Plumbing for handling SW scripts failing to evaluate : [Attachment 325623] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 178926: Plumbing for handling SW scripts failing to evaluate
https://bugs.webkit.org/show_bug.cgi?id=178926

Attachment 325623: Patch

https://bugs.webkit.org/attachment.cgi?id=325623&action=review




--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 325623
  --> https://bugs.webkit.org/attachment.cgi?id=325623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325623&action=review

r=me assuming the bots are happy.

> Source/WebCore/workers/WorkerThread.cpp:190
> +    if (m_hasEvaluateCallback) {

This is just to avoid a dispatch? If so, I am personally not sure it is worth
an extra member. We could do inside the lambda:
if (evaluateCallback)
    evaluateCallback(message);