[webkit-reviews] review granted: [Bug 175275] [Win] Detect Visual Studio 2017 location : [Attachment 325591] Use vswhere to determine visual studio location - make new modules require only in new paths

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 175275: [Win] Detect Visual Studio 2017 location
https://bugs.webkit.org/show_bug.cgi?id=175275

Attachment 325591: Use vswhere to determine visual studio location - make new
modules require only in new paths

https://bugs.webkit.org/attachment.cgi?id=325591&action=review




--- Comment #37 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 325591
  --> https://bugs.webkit.org/attachment.cgi?id=325591
Use vswhere to determine visual studio location - make new modules require only
in new paths

View in context: https://bugs.webkit.org/attachment.cgi?id=325591&action=review

> Tools/Scripts/webkitdirs.pm:600
> +    require Encode;
> +    require Encode::Locale;
> +    require JSON::PP;

Let's extract this part to a subroutine.

> Tools/Scripts/webkitdirs.pm:639
> +    require Encode;
> +    require Encode::Locale;
> +    require JSON::PP;

Ditto.