[webkit-reviews] review granted: [Bug 175597] XMLHttpRequest should not sniff content encoding : [Attachment 325365] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 175597: XMLHttpRequest should not sniff content encoding
https://bugs.webkit.org/show_bug.cgi?id=175597

Attachment 325365: Patch

https://bugs.webkit.org/attachment.cgi?id=325365&action=review




--- Comment #34 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 325365
  --> https://bugs.webkit.org/attachment.cgi?id=325365
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325365&action=review

> Source/WebCore/platform/network/PingHandle.h:55
> +	   bool defersLoading = false;

It would be nice if these were two-state enums.
enum class DefersLoading { No, Yes };

> LayoutTests/platform/mac/TestExpectations:35
> +http/tests/xmlhttprequest/gzip-content-type-no-content-encoding.html [ Skip
]

I think this could be marked as pass/fail instead of skipping.