[webkit-reviews] review granted: [Bug 179114] First letter text renderer should be anonymous : [Attachment 325576] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 1 09:37:01 PDT 2017


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 179114: First letter text renderer should be anonymous
https://bugs.webkit.org/show_bug.cgi?id=179114

Attachment 325576: patch

https://bugs.webkit.org/attachment.cgi?id=325576&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 325576
  --> https://bugs.webkit.org/attachment.cgi?id=325576
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325576&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:131
> +typedef HashMap<const RenderBoxModelObject*, WeakPtr<RenderTextFragment>>
FirstLetterRemainingTextMap;

In new code it’s nice to use "using" instead of typedef.


More information about the webkit-reviews mailing list