[webkit-reviews] review granted: [Bug 172798] [JSC] Implement String.prototype.concat in JS builtins : [Attachment 311683] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Yusuke Suzuki <utatane.tea at gmail.com>'s
request for review:
Bug 172798: [JSC] Implement String.prototype.concat in JS builtins
https://bugs.webkit.org/show_bug.cgi?id=172798

Attachment 311683: Patch

https://bugs.webkit.org/attachment.cgi?id=311683&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 311683
  --> https://bugs.webkit.org/attachment.cgi?id=311683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311683&action=review

> Source/JavaScriptCore/builtins/StringPrototype.js:311
> +function stringConcatSlowPath()
> +{
> +    "use strict";

Is using arguments faster than using rest parameters? (I asked Saam recently
and he was on the fence I think, or maybe just hadn't benchmarked it).