[webkit-reviews] review granted: [Bug 162673] [GTK] Cache RenderThemeGadget hierarchies for rendering themed elements with GTK+ 3.20+ : [Attachment 311127] Try to fix the build with older GTK+

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 162673: [GTK] Cache RenderThemeGadget hierarchies for rendering themed
elements with GTK+ 3.20+
https://bugs.webkit.org/show_bug.cgi?id=162673

Attachment 311127: Try to fix the build with older GTK+

https://bugs.webkit.org/attachment.cgi?id=311127&action=review




--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 311127
  --> https://bugs.webkit.org/attachment.cgi?id=311127
Try to fix the build with older GTK+

View in context: https://bugs.webkit.org/attachment.cgi?id=311127&action=review

I've restored to just skimming this, since I've had it open awaiting review for
over a week now, and it looks fine. Thanks for working on this massive effort.
Please don't backport it; you never know what odd themes could break.

> Source/WebCore/platform/gtk/RenderThemeWidget.cpp:176
> +    RenderThemeGadget::Info info = {
> +	   .type = RenderThemeGadget::Type::Generic,
> +	   .name = toggleType == Type::Check ? "checkbutton" : "radiobutton",
> +	   .classList = { "text-button" }
> +    };

Let's not use nonstandard designated initializers (see bug #172667)