[webkit-reviews] review denied: [Bug 132333] [CLOOP] Operand in PutToScope and GetFromScope is not set right causing crashes on big endian arches : [Attachment 311588] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Tomas Popela <tpopela at redhat.com>'s
request for review:
Bug 132333: [CLOOP] Operand in PutToScope and GetFromScope is not set right
causing crashes on big endian arches
https://bugs.webkit.org/show_bug.cgi?id=132333

Attachment 311588: Patch

https://bugs.webkit.org/attachment.cgi?id=311588&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 311588
  --> https://bugs.webkit.org/attachment.cgi?id=311588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311588&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   The operand in PutToScope and GetFromScope instructions is not set

I'm surprised that other opcodes don't suffer from this as well.

> Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:1633
> +	   intptr_t operand = getOperand(*(++it), type); // Operand

nit: This comment seems out of date given it now reads "operand getOperand //
operand"

Same as above

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:662
> +	       if (op.type == ClosureVar || op.type ==
ClosureVarWithVarInjectionChecks || op.type == GlobalProperty || op.type ==
GlobalPropertyWithVarInjectionChecks)

This does not look complete. I think ModuleVar also uses this as a int value.