[webkit-reviews] review granted: [Bug 172771] PeerConnection should respect tracks that are muted at the time they are added : [Attachment 311622] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 172771: PeerConnection should respect tracks that are muted at the time
they are added
https://bugs.webkit.org/show_bug.cgi?id=172771

Attachment 311622: Patch

https://bugs.webkit.org/attachment.cgi?id=311622&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 311622
  --> https://bugs.webkit.org/attachment.cgi?id=311622
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311622&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:105
> +    if (!m_muted && m_enabled && m_blackFrameTimer.isActive()) {
> +	   m_blackFrameTimer.stop();
>	   return;
>      }
> -    if (m_blackFrameTimer.isActive())
> -	   m_blackFrameTimer.stop();
> +
> +    sendBlackFramesIfNeeded();

I would be nice to factor this into a function that can be shared with
sourceMutedChanged.