[webkit-reviews] review granted: [Bug 172750] [CMake] Do not pass -Wno-expansion-to-defined to Clang <4.0.0 : [Attachment 311589] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 31 12:44:03 PDT 2017
Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 172750: [CMake] Do not pass -Wno-expansion-to-defined to Clang <4.0.0
https://bugs.webkit.org/show_bug.cgi?id=172750
Attachment 311589: Patch
https://bugs.webkit.org/attachment.cgi?id=311589&action=review
--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 311589
--> https://bugs.webkit.org/attachment.cgi?id=311589
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=311589&action=review
> Source/cmake/OptionsCommon.cmake:37
> + if (NOT(COMPILER_IS_CLANG AND "${CLANG_VERSION}" VERSION_LESS 4.0.0))
Style: add one space after the NOT
More information about the webkit-reviews
mailing list