[webkit-reviews] review granted: [Bug 172730] Make ResourceLoadStatistics testing more reliable : [Attachment 311574] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 31 09:21:28 PDT 2017


Andy Estes <aestes at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 172730: Make ResourceLoadStatistics testing more reliable
https://bugs.webkit.org/show_bug.cgi?id=172730

Attachment 311574: Patch

https://bugs.webkit.org/attachment.cgi?id=311574&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 311574
  --> https://bugs.webkit.org/attachment.cgi?id=311574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311574&action=review

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:146
> +	       RunLoop::main().dispatch([this, protectedThis = makeRef(*this)]
() mutable {
> +		  
WebProcessProxy::notifyPageStatisticsAndDataRecordsProcessed();
> +	       });

It's not obvious why `this` has to be captured here since the lambda calls a
static function.


More information about the webkit-reviews mailing list