[webkit-reviews] review granted: [Bug 172736] bmalloc: Some refactoring to prepare for optimization : [Attachment 311546] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 30 16:41:47 PDT 2017


Michael Saboff <msaboff at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 172736: bmalloc: Some refactoring to prepare for optimization
https://bugs.webkit.org/show_bug.cgi?id=172736

Attachment 311546: Patch

https://bugs.webkit.org/attachment.cgi?id=311546&action=review




--- Comment #2 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 311546
  --> https://bugs.webkit.org/attachment.cgi?id=311546
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311546&action=review

r=me

> Source/bmalloc/bmalloc/VMHeap.cpp:-79
> -    vmRevokePermissions(begin.address(), vmPageSize);
> -    vmRevokePermissions(end.address() - vmPageSize, vmPageSize);

Why do we no longer need guard pages around small chunks?


More information about the webkit-reviews mailing list