[webkit-reviews] review granted: [Bug 172602] [WebRTC] Prevent capturing at unconventional resolutions when using the SW encoder on Mac : [Attachment 311376] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 172602: [WebRTC] Prevent capturing at unconventional resolutions when using
the SW encoder on Mac
https://bugs.webkit.org/show_bug.cgi?id=172602

Attachment 311376: Patch

https://bugs.webkit.org/attachment.cgi?id=311376&action=review




--- Comment #30 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 311376
  --> https://bugs.webkit.org/attachment.cgi?id=311376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311376&action=review

> Source/WebCore/ChangeLog:12
> +	   Adding internal API to switch on/off hardware H264 encoder.
> +	   Adding checks for standard size. If using a software encoder and
frame size is not standard,

Nit: "Adding" => "Add"

> LayoutTests/webrtc/captureCanvas-webrtc.html:49
> +    if (video.videoWidth === width && videoi.videoHeight === height)

Nit: "videoi"