[webkit-reviews] review granted: [Bug 172633] Only include DataDetectorsUI headers in iOS : [Attachment 311416] Disables data detections entirely

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 172633: Only include DataDetectorsUI headers in iOS
https://bugs.webkit.org/show_bug.cgi?id=172633

Attachment 311416: Disables data detections entirely

https://bugs.webkit.org/attachment.cgi?id=311416&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 311416
  --> https://bugs.webkit.org/attachment.cgi?id=311416
Disables data detections entirely

View in context: https://bugs.webkit.org/attachment.cgi?id=311416&action=review

r=me

> Source/WTF/wtf/Platform.h:552
>  #define HAVE_AVKIT 1
>  #define HAVE_PARENTAL_CONTROLS 1
> +#define ENABLE_DATA_DETECTION 1

Nit:  Please alphabetize by full macro name (so ENABLE_* would come before
HAVE_*).

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:56
> +#if ENABLE(DATA_DETECTION)
>  #import "WKDataDetectorTypesInternal.h"
> +#endif

Are we still putting these in a separate section after the default list of
#import statements?

>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandl
e.mm:34
> +#if ENABLE(DATA_DETECTION)
>  #import "WKDataDetectorTypesInternal.h"
> +#endif

Move to after default list of #import statements?