[webkit-reviews] review granted: [Bug 172709] [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky. : [Attachment 311500] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 172709: [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is
flaky.
https://bugs.webkit.org/show_bug.cgi?id=172709

Attachment 311500: Patch

https://bugs.webkit.org/attachment.cgi?id=311500&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 311500
  --> https://bugs.webkit.org/attachment.cgi?id=311500
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311500&action=review

R=me but please make a new IWebViewPrivate5 interface to avoid breaking
existing COM interface users.

> Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350
> +    HRESULT exitFullscreenIfNeeded();

Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4
already shipped to users, and we will break them if we modify the COM
interface.