[webkit-reviews] review granted: [Bug 172705] [css-align] Import W3C web platform tests for the CSS Box Alignment feature : [Attachment 311499] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 172705: [css-align] Import W3C web platform tests for the CSS Box Alignment
feature
https://bugs.webkit.org/show_bug.cgi?id=172705

Attachment 311499: Patch

https://bugs.webkit.org/attachment.cgi?id=311499&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 311499
  --> https://bugs.webkit.org/attachment.cgi?id=311499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311499&action=review

r=me once EWSs are happy.

> LayoutTests/TestExpectations:644
> +# Imported W3C css-align-3 tests that are failing.
> +webkit.org/b/172707
imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-short
hand-006.html [ Failure ]
> +webkit.org/b/172707
imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-s
horthand-006.html [ Failure ]

I don't think you need those lines, as you're adding the -expected.txt files
with FAIL messages these tests will be passing.

And this seems to be the preferred choice, check this comment:
https://bugs.webkit.org/show_bug.cgi?id=170935#c6

So remove these lines from here and the rest looks good.