[webkit-reviews] review granted: [Bug 172690] [JSC] Provide better type information of toLength and tighten bytecode : [Attachment 311449] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Yusuke Suzuki <utatane.tea at gmail.com>'s
request for review:
Bug 172690: [JSC] Provide better type information of toLength and tighten
bytecode
https://bugs.webkit.org/show_bug.cgi?id=172690

Attachment 311449: Patch

https://bugs.webkit.org/attachment.cgi?id=311449&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 311449
  --> https://bugs.webkit.org/attachment.cgi?id=311449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311449&action=review

> Source/JavaScriptCore/ChangeLog:15
> +	   operator+ emits to_number bytecode. What this bytecode does is the
same
> +	   to @Number() call. It is more efficient, and it is smaller bytecode
> +	   than @Number() call (load global variable @Number, set up arguments,
and
> +	   call it).

Should we remove @Number()? Alternatively, should we make @Number() transform
into to_number (maybe via your bytecode re-writer )?