[webkit-reviews] review granted: [Bug 141515] Web Inspector: images dragged from Inspector to Desktop are named "Unknown.png" : [Attachment 311410] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 141515: Web Inspector: images dragged from Inspector to Desktop are named
"Unknown.png"
https://bugs.webkit.org/show_bug.cgi?id=141515

Attachment 311410: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=311410&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 311410
  --> https://bugs.webkit.org/attachment.cgi?id=311410
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=311410&action=review

> Source/WebCore/html/HTMLAttributeNames.in:120
> +filename

Hm, it's somewhat surprising that filename wasn't present here before.

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:177
> +    String filename = String([response suggestedFilename]);

auto filename

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:179
> +	   String downloadFilename =
ResourceResponseBase::sanitizeSuggestedFilename(element.attributeWithoutSynchro
nization(HTMLNames::filenameAttr));

auto :)