[webkit-reviews] review denied: [Bug 171265] test262: Completion values for control flow do not match the spec : [Attachment 311422] [PATCH] Proposed Fix v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 27 17:35:50 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 171265: test262: Completion values for control flow do not match the spec
https://bugs.webkit.org/show_bug.cgi?id=171265

Attachment 311422: [PATCH] Proposed Fix v3

https://bugs.webkit.org/attachment.cgi?id=311422&action=review




--- Comment #29 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 311422
  --> https://bugs.webkit.org/attachment.cgi?id=311422
[PATCH] Proposed Fix v3

View in context: https://bugs.webkit.org/attachment.cgi?id=311422&action=review

> Source/JavaScriptCore/parser/Nodes.cpp:83
> +bool SourceElements::hasEarlyBreak() const

This isn't enough, it needs to allow for continue as well. For example:

    assert.sameValue(
      eval('12; do { 13; if (true) { continue; } 14; } while (false)'),
undefined
    );


More information about the webkit-reviews mailing list