[webkit-reviews] review granted: [Bug 29084] getComputedStyle returns percentage values for left / right / top / bottom : [Attachment 311407] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 29084: getComputedStyle returns percentage values for left / right / top /
bottom
https://bugs.webkit.org/show_bug.cgi?id=29084

Attachment 311407: Patch

https://bugs.webkit.org/attachment.cgi?id=311407&action=review




--- Comment #104 from zalan <zalan at apple.com> ---
Comment on attachment 311407
  --> https://bugs.webkit.org/attachment.cgi?id=311407
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311407&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:796
> +    RenderBlock* containingBlock = box.containingBlock();

auto*

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2261
> +    return renderer && style && renderer->isBox();

I'd write it like this: return style && renderer && renderer->isBox();