[webkit-reviews] review denied: [Bug 162515] Web Inspector: Pretty print / type info / code coverage buttons disappear after switching tabs : [Attachment 311405] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied  review:
Bug 162515: Web Inspector: Pretty print / type info / code coverage buttons
disappear after switching tabs
https://bugs.webkit.org/show_bug.cgi?id=162515

Attachment 311405: Patch

https://bugs.webkit.org/attachment.cgi?id=311405&action=review




--- Comment #5 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 311405

  --> https://bugs.webkit.org/attachment.cgi?id=311405&action=review

Patch

(In reply to Nikita Vasilyev from comment #4)
> The bug reproduces when switching from Debugger to Resources (or vice versa)
> and when (and only when) the both tabs have the same selected script file.
> 
> _updateContentViewNavigationItems doesn't necessarily get called when
> switching tabs. Always calling it when switching tabs would be one way of
> solving this.

I tried this approach and it worked.

I made updateContentViewNavigationItems public. I'll try to find a more elegant
way of fixing it that doesn't require making _updateContentViewNavigationItems
public.