[webkit-reviews] review granted: [Bug 172480] [WebIDL] Overloaded functions should throw this object check exception before argument check exception : [Attachment 311400] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 172480: [WebIDL] Overloaded functions should throw this object check
exception before argument check exception
https://bugs.webkit.org/show_bug.cgi?id=172480

Attachment 311400: Patch

https://bugs.webkit.org/attachment.cgi?id=311400&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 311400
  --> https://bugs.webkit.org/attachment.cgi?id=311400
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311400&action=review

r=me

> Source/WebCore/ChangeLog:13
> +	   - Made is so all operations, including static ones, use the
trampoline / body model,

made *it* ?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4401
> +    assert("[Custom] is not support for overloaded operations.") if
$isCustom && $isOverloaded;

*supported*

> Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:393
> +static inline JSC::EncodedJSValue
jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperationBody2(JSC::ExecState
* state, typename IDLOperation<JSTestGlobalObject>::ClassParameter castedThis,
JSC::ThrowScope& throwScope)

My personal preference would have been Operation2Body rather than
OperationBody2.

> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:886
> +static inline JSC::EncodedJSValue
jsTestInterfacePrototypeFunctionSupplementalMethod2Body(JSC::ExecState* state,
typename IDLOperation<JSTestInterface>::ClassParameter castedThis,
JSC::ThrowScope& throwScope)

Notice that the format here is Method2Body, not MethodBody2.