[webkit-reviews] review granted: [Bug 172654] REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject(). : [Attachment 311386] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 172654: REEGRESSION(r217459): testapi fails in JSExportTest's
wrapperForNSObjectisObject().
https://bugs.webkit.org/show_bug.cgi?id=172654

Attachment 311386: Patch

https://bugs.webkit.org/attachment.cgi?id=311386&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 311386
  --> https://bugs.webkit.org/attachment.cgi?id=311386
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review

r=me with suggestion.

> Source/JavaScriptCore/ChangeLog:8
> +	   Fix the test to make sure we don't not check for an exception.

How about rephrasing this as:
The test's intent is to assert that an exception has not been thrown (as
indicated by the message string), but the test was erroneously checking for the
opposite condition.  This is now fixed.