[webkit-reviews] review requested: [Bug 172603] [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser : [Attachment 311377] Patch and unit tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 26 14:43:25 PDT 2017
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 172603: [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support
onbeforeunload confirm panel in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=172603
Attachment 311377: Patch and unit tests
https://bugs.webkit.org/attachment.cgi?id=311377&action=review
--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Created attachment 311377
--> https://bugs.webkit.org/attachment.cgi?id=311377&action=review
Patch and unit tests
Updated patch to prefix WKUIDelegate SPI with an underscore and add
WK_API_AVAILABLE() annotation as pointed out by Dan Bernstein in comment #17.
More information about the webkit-reviews
mailing list