[webkit-reviews] review granted: [Bug 172622] Web Inspector: Reloading the page after switching from the Resource tab switches back : [Attachment 311316] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172622: Web Inspector: Reloading the page after switching from the Resource
tab switches back
https://bugs.webkit.org/show_bug.cgi?id=172622

Attachment 311316: Patch

https://bugs.webkit.org/attachment.cgi?id=311316&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 311316
  --> https://bugs.webkit.org/attachment.cgi?id=311316
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311316&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:433
> +	   if (!this.visible)
> +	       return;

Why don't other sidebars do this as well? Storage does. But why not
Debugger/Search?

I suggest solving it for other tabs as well before it pops up on them.

Great sleuthing.