[webkit-reviews] review granted: [Bug 172649] webrtc/peer-connection-audio-mute.html is sometimes flaky : [Attachment 311360] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 26 10:27:18 PDT 2017


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 172649: webrtc/peer-connection-audio-mute.html is sometimes flaky
https://bugs.webkit.org/show_bug.cgi?id=172649

Attachment 311360: Patch

https://bugs.webkit.org/attachment.cgi?id=311360&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 311360
  --> https://bugs.webkit.org/attachment.cgi?id=311360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311360&action=review

> LayoutTests/webrtc/peer-connection-audio-mute.html:13
> +    function ensureHumIsAsExpected(remoteStream, heardHum, count)

I think we should rename heardHum here to shouldHeadHum since this is an
expected result, not a result.


More information about the webkit-reviews mailing list