[webkit-reviews] review granted: [Bug 172011] [CredentialManagement] Incorporate IDL updates from latest spec : [Attachment 311254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 26 09:27:38 PDT 2017 

Daniel Bates <dbates at webkit.org> has granted Ali Juma <ajuma at chromium.org>'s
request for review:
Bug 172011: [CredentialManagement] Incorporate IDL updates from latest spec
https://bugs.webkit.org/show_bug.cgi?id=172011

Attachment 311254: Patch

https://bugs.webkit.org/attachment.cgi?id=311254&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 311254
  --> https://bugs.webkit.org/attachment.cgi?id=311254
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311254&action=review

I noticed some minor nits.

r=me

> Source/WebCore/Modules/credentials/CredentialUserData.idl:26
> +[   NoInterfaceObject,

The '[' should be on its own line.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:11058
> +		77AAD67C1ECCF06E00BFA2D1 /* CredentialUserData.idl */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
CredentialUserData.idl; sourceTree = "<group>"; };
> +		77AAD67D1ECDE8FB00BFA2D1 /* CredentialUserData.h */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
CredentialUserData.h; sourceTree = "<group>"; };
> +		77AAD67F1ECF6A3D00BFA2D1 /* FederatedCredential.idl */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
FederatedCredential.idl; sourceTree = "<group>"; };
> +		77AAD6801ECF6C4100BFA2D1 /* FederatedCredential.h */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
FederatedCredential.h; sourceTree = "<group>"; };
> +		77AAD6811ECF8D3800BFA2D1 /* FederatedCredential.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = FederatedCredential.cpp; sourceTree = "<group>"; };
> +		77AAD6831ECFB66200BFA2D1 /* CredentialCreationOptions.idl */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
CredentialCreationOptions.idl; sourceTree = "<group>"; };
> +		77AAD6851ECFBD3900BFA2D1 /* CredentialCreationOptions.h */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
CredentialCreationOptions.h; sourceTree = "<group>"; };
> +		77CD167D1ED3BDB8009E9536 /* FederatedCredentialInit.idl */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
FederatedCredentialInit.idl; sourceTree = "<group>"; };
> +		77CD167E1ED3BE11009E9536 /* FederatedCredentialInit.h */ = {isa
= PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
FederatedCredentialInit.h; sourceTree = "<group>"; };
> +		77CD167F1ED3C2DB009E9536 /* PasswordCredentialData.idl */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
PasswordCredentialData.idl; sourceTree = "<group>"; };
> +		77CD16801ED3C32A009E9536 /* PasswordCredentialData.h */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path
= PasswordCredentialData.h; sourceTree = "<group>"; };
> +		77D50FFA1ED4EC7800DA4C87 /* CredentialRequestOptions.idl */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
CredentialRequestOptions.idl; sourceTree = "<group>"; };
> +		77D50FFB1ED4F16C00DA4C87 /* CredentialRequestOptions.h */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
path = CredentialRequestOptions.h; sourceTree = "<group>"; };
> +		77D50FFC1ED4F70C00DA4C87 /* JSCredentialCreationOptions.cpp */
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.cpp; path = JSCredentialCreationOptions.cpp; sourceTree =
"<group>"; };
> +		77D50FFD1ED4F70C00DA4C87 /* JSCredentialCreationOptions.h */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
path = JSCredentialCreationOptions.h; sourceTree = "<group>"; };
> +		77D50FFE1ED4F70C00DA4C87 /* JSCredentialRequestOptions.cpp */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.cpp; path = JSCredentialRequestOptions.cpp; sourceTree =
"<group>"; };
> +		77D50FFF1ED4F70C00DA4C87 /* JSCredentialRequestOptions.h */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
path = JSCredentialRequestOptions.h; sourceTree = "<group>"; };
> +		77D510001ED4F70C00DA4C87 /* JSCredentialUserData.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = JSCredentialUserData.cpp; sourceTree = "<group>"; };
> +		77D510011ED4F70C00DA4C87 /* JSCredentialUserData.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
JSCredentialUserData.h; sourceTree = "<group>"; };
> +		77D510081ED5E21800DA4C87 /*
FederatedCredentialRequestOptions.idl */ = {isa = PBXFileReference;
fileEncoding = 4; lastKnownFileType = text; path =
FederatedCredentialRequestOptions.idl; sourceTree = "<group>"; };
> +		77D510091ED5E26F00DA4C87 /* FederatedCredentialRequestOptions.h
*/ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.c.h; path = FederatedCredentialRequestOptions.h; sourceTree =
"<group>"; };
> +		77D510111ED5F4E700DA4C87 /*
JSFederatedCredentialRequestOptions.cpp */ = {isa = PBXFileReference;
fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path =
JSFederatedCredentialRequestOptions.cpp; sourceTree = "<group>"; };
> +		77D510121ED5F4E700DA4C87 /*
JSFederatedCredentialRequestOptions.h */ = {isa = PBXFileReference;
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
JSFederatedCredentialRequestOptions.h; sourceTree = "<group>"; };
> +		77D510151ED6001B00DA4C87 /* CredentialsContainer.idl */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
CredentialsContainer.idl; sourceTree = "<group>"; };
> +		77D510161ED6021B00DA4C87 /* CredentialsContainer.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
CredentialsContainer.h; sourceTree = "<group>"; };
> +		77D510181ED7159900DA4C87 /* CredentialsContainer.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = CredentialsContainer.cpp; sourceTree = "<group>"; };
> +		77D5101A1ED722B500DA4C87 /* JSCredentialsContainer.cpp */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.cpp; path = JSCredentialsContainer.cpp; sourceTree = "<group>";
};
> +		77D5101B1ED722B500DA4C87 /* JSCredentialsContainer.h */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path
= JSCredentialsContainer.h; sourceTree = "<group>"; };
> +		77D5101E1ED72BDB00DA4C87 /* NavigatorCredentials.idl */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path =
NavigatorCredentials.idl; sourceTree = "<group>"; };
> +		77D5101F1ED72D5C00DA4C87 /* NavigatorCredentials.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
NavigatorCredentials.h; sourceTree = "<group>"; };
> +		77D510211ED7340A00DA4C87 /* NavigatorCredentials.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = NavigatorCredentials.cpp; sourceTree = "<group>"; wrapsLines = 1; };
> +		77D510231ED74B5500DA4C87 /* JSNavigatorCredentials.cpp */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.cpp; path = JSNavigatorCredentials.cpp; sourceTree = "<group>";
};
> +		77D510241ED74B5500DA4C87 /* JSNavigatorCredentials.h */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path
= JSNavigatorCredentials.h; sourceTree = "<group>"; };

Please add these entries such that they are in sorted order according to the
UNIX sort command. You may find it more time-efficient to do this by hand or
use Tools/Scripts/sort-Xcode-project-file (though this sorts everything)
instead of fixing the ordering in Xcode.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:18652
> +				77D510231ED74B5500DA4C87 /*
JSNavigatorCredentials.cpp */,
> +				77D510241ED74B5500DA4C87 /*
JSNavigatorCredentials.h */,
> +				77D5101A1ED722B500DA4C87 /*
JSCredentialsContainer.cpp */,
> +				77D5101B1ED722B500DA4C87 /*
JSCredentialsContainer.h */,
> +				77D510111ED5F4E700DA4C87 /*
JSFederatedCredentialRequestOptions.cpp */,
> +				77D510121ED5F4E700DA4C87 /*
JSFederatedCredentialRequestOptions.h */,
> +				77D50FFC1ED4F70C00DA4C87 /*
JSCredentialCreationOptions.cpp */,
> +				77D50FFD1ED4F70C00DA4C87 /*
JSCredentialCreationOptions.h */,
> +				77D50FFE1ED4F70C00DA4C87 /*
JSCredentialRequestOptions.cpp */,
> +				77D50FFF1ED4F70C00DA4C87 /*
JSCredentialRequestOptions.h */,
> +				77D510001ED4F70C00DA4C87 /*
JSCredentialUserData.cpp */,
> +				77D510011ED4F70C00DA4C87 /*
JSCredentialUserData.h */,
> +				77534FF31ED4C99F00A9646E /*
JSPasswordCredentialData.cpp */,
> +				77534FF41ED4C99F00A9646E /*
JSPasswordCredentialData.h */,
> +				77534FEF1ED4C96B00A9646E /*
JSFederatedCredential.cpp */,
> +				77534FF01ED4C96B00A9646E /*
JSFederatedCredential.h */,
> +				77534FF11ED4C96B00A9646E /*
JSFederatedCredentialInit.cpp */,
> +				77534FF21ED4C96B00A9646E /*
JSFederatedCredentialInit.h */,

Please add these entries to such that they are in sorted order with the
existing files according to the UNIX sort command.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26591
> +				77D510251ED74B5800DA4C87 /*
JSNavigatorCredentials.h in Headers */,

Please add this entries such it is in sorted order according with the other
headers.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27014
> +				77D5100F1ED5E2A200DA4C87 /*
FederatedCredential.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27051
> +				77D510171ED6022200DA4C87 /*
CredentialsContainer.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27349
> +				77D5100D1ED5E29500DA4C87 /*
CredentialCreationOptions.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27853
> +				77D510131ED5F4ED00DA4C87 /*
JSFederatedCredentialRequestOptions.h in Headers */,
>				7C45C9D41E3FCBDF00AAB558 /*
JSDOMBindingSecurity.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28022
> +				77D5100E1ED5E29B00DA4C87 /*
CredentialUserData.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28196
> +				77D510201ED72D5F00DA4C87 /*
NavigatorCredentials.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28482
> +				77D50FF41ED4D98D00DA4C87 /*
JSFederatedCredentialInit.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29098
> +				77D510101ED5E2C900DA4C87 /*
FederatedCredentialInit.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29183
> +				77D5101C1ED722BF00DA4C87 /*
JSCredentialsContainer.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29232
> +				77D5100A1ED5E28500DA4C87 /*
FederatedCredentialRequestOptions.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29250
> +				77D510021ED4F71800DA4C87 /*
JSCredentialUserData.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29501
> +				77D510061ED4F72500DA4C87 /*
JSCredentialCreationOptions.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29818
> +				77D5100C1ED5E29000DA4C87 /*
PasswordCredentialData.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29895
> +				77D50FF81ED4D9A000DA4C87 /*
JSPasswordCredentialData.h in Headers */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:30619
> +				77AAD6821ECF8D3800BFA2D1 /*
FederatedCredential.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:30783
> +				77D510051ED4F72200DA4C87 /*
JSCredentialRequestOptions.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:31088
> +				77D5101D1ED722C300DA4C87 /*
JSCredentialsContainer.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:31314
> +				77D510261ED74B5C00DA4C87 /*
JSNavigatorCredentials.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:32152
> +				77D510031ED4F71B00DA4C87 /*
JSCredentialUserData.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:32523
> +				77D510191ED715AC00DA4C87 /*
CredentialsContainer.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:32596
> +				77D50FF91ED4D9A400DA4C87 /*
JSPasswordCredentialData.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:32793
> +				77D50FF71ED4D99D00DA4C87 /*
JSFederatedCredential.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33214
> +				77D510141ED5F4F100DA4C87 /*
JSFederatedCredentialRequestOptions.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33476
> +				77D510071ED4F72700DA4C87 /*
JSCredentialCreationOptions.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33602
> +				77D510221ED7364500DA4C87 /*
NavigatorCredentials.cpp in Sources */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33847
> +				77D50FF51ED4D99100DA4C87 /*
JSFederatedCredentialInit.cpp in Sources */,

Ditto.

More information about the webkit-reviews mailing list