[webkit-reviews] review granted: [Bug 172364] Reduce Safari Technology Preview Release Notes posts shown on homepage : [Attachment 310667] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 172364: Reduce Safari Technology Preview Release Notes posts shown on
homepage
https://bugs.webkit.org/show_bug.cgi?id=172364

Attachment 310667: Patch

https://bugs.webkit.org/attachment.cgi?id=310667&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 310667
  --> https://bugs.webkit.org/attachment.cgi?id=310667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310667&action=review

Looks sane to me

> Websites/webkit.org/ChangeLog:8
> +	   * wp-content/themes/webkit/functions.php: Load some extra posts

Nit: Missing period at the end of this sentence.

> Websites/webkit.org/ChangeLog:9
> +	   * wp-content/themes/webkit/widgets/post.php: Show STP blog posts
when it is the current featured post

Ditto.

> Websites/webkit.org/wp-content/themes/webkit/functions.php:420
> +	   

Please remove this whitespace.

> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:35
> +	   if ( ! $featured) {

Nit: Missing space before the ')'.

> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:36
> +	       // Prevent Safari Technology Preview release note posts from
showing up when not a featured post

Nit: Missing a period at the end of this sentence.