[webkit-reviews] review requested: [Bug 172603] [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser : [Attachment 311334] Patch and unit tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 172603: [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support
onbeforeunload confirm panel in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=172603

Attachment 311334: Patch and unit tests

https://bugs.webkit.org/attachment.cgi?id=311334&action=review




--- Comment #11 from Daniel Bates <dbates at webkit.org> ---
Created attachment 311334

  --> https://bugs.webkit.org/attachment.cgi?id=311334&action=review

Patch and unit tests

Updated patch to fix the GTK EWS, updated comments in unit test
Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to reference bug #172614.
Removed PLATFORM(MAC)-guarded code from
Tools/TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp as this test does not run
on iOS (since we do not enable the WebKit C SPI on iOS) and GTK does not seem
to run many WebKit2 C SPI tests (why?).