[webkit-reviews] review granted: [Bug 125565] Frame's composited content is visible when the frame has visibility: hidden. : [Attachment 311325] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 125565: Frame's composited content is visible when the frame has
visibility: hidden.
https://bugs.webkit.org/show_bug.cgi?id=125565

Attachment 311325: Patch

https://bugs.webkit.org/attachment.cgi?id=311325&action=review




--- Comment #49 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 311325
  --> https://bugs.webkit.org/attachment.cgi?id=311325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311325&action=review

> LayoutTests/compositing/visibility/iframe-visibility-hidden.html:14
> +    document.getElementById("divToVisible").style.visibility = "visible";

But divToVisible (which is actually an iframe) is already visible?

> LayoutTests/compositing/visibility/iframe-visibility-hidden.html:44
> +<iframe frameborder=no id=divToVisible onload="makeDivVisible()" width="80"
height="80" style="visibility: visible"

Should this start hidden?