[webkit-reviews] review requested: [Bug 172603] [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser : [Attachment 311298] Patch and unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 25 14:59:37 PDT 2017


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 172603: [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support
onbeforeunload confirm panel in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=172603

Attachment 311298: Patch and unit tests

https://bugs.webkit.org/attachment.cgi?id=311298&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Created attachment 311298

  --> https://bugs.webkit.org/attachment.cgi?id=311298&action=review

Patch and unit tests

Updated patch to disable unit the runBeforeUnloadConfirmPanel tests on iOS as
we do not have the infrasturcture to simulate a tap/click at the moment. Also,
updated ChangeLog entries in the patch to reflect the updated title.


More information about the webkit-reviews mailing list