[webkit-reviews] review granted: [Bug 172604] Regression(r215686): Videos sometimes do not load in iBooks : [Attachment 311294] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172604: Regression(r215686): Videos sometimes do not load in iBooks
https://bugs.webkit.org/show_bug.cgi?id=172604

Attachment 311294: Patch

https://bugs.webkit.org/attachment.cgi?id=311294&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 311294
  --> https://bugs.webkit.org/attachment.cgi?id=311294
Patch

r=me

This seems like another case where SharedBuffer could offer a helper function
to encapsulate behavior and avoid bugs.

In this case, I would offer a function that returned a boolean indicating
whether it satisfied the full read request.