[webkit-reviews] review denied: [Bug 172606] Web Inspector: Changing the width of a Sidebar when it's collapsed shouldn't trigger a layout : [Attachment 311281] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172606: Web Inspector: Changing the width of a Sidebar when it's collapsed
shouldn't trigger a layout
https://bugs.webkit.org/show_bug.cgi?id=172606

Attachment 311281: Patch

https://bugs.webkit.org/attachment.cgi?id=311281&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 311281
  --> https://bugs.webkit.org/attachment.cgi?id=311281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311281&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:1630
>  WebInspector._sidebarWidthDidChange = function(event)
>  {
> +    if (event.target.collapsed)
> +	   return;
> +
>      this._tabBrowserSizeDidChange();
>  };

This does not appear to be correct. When a tab is collapsed we want to run
_tabBrowserSizeDidChange.