[webkit-reviews] review denied: [Bug 172602] [WebRTC] Prevent capturing at unconventional resolutions when using the SW encoder on Mac : [Attachment 311273] Patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 172602: [WebRTC] Prevent capturing at unconventional resolutions when using
the SW encoder on Mac
https://bugs.webkit.org/show_bug.cgi?id=172602

Attachment 311273: Patch

https://bugs.webkit.org/attachment.cgi?id=311273&action=review




--- Comment #9 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 311273
  --> https://bugs.webkit.org/attachment.cgi?id=311273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311273&action=review

r- with lack of test for non-standard resolution.

> Source/ThirdParty/libwebrtc/ChangeLog:3
> +	   fix-172602

?

> Source/ThirdParty/libwebrtc/ChangeLog:20
> +	   *
Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:

Double Changelog.

> LayoutTests/ChangeLog:9
> +	   * webrtc/captureCanvas-webrtc.html: Using standard resolutions.

we should have a test with expected behavior of non-standard resolutions as
well.