[webkit-reviews] review granted: [Bug 172578] DocumentThreadableLoader::redirectReceived() should not rely on the resource's loader : [Attachment 311259] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 25 13:07:56 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172578: DocumentThreadableLoader::redirectReceived() should not rely on the
resource's loader
https://bugs.webkit.org/show_bug.cgi?id=172578

Attachment 311259: Patch

https://bugs.webkit.org/attachment.cgi?id=311259&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 311259
  --> https://bugs.webkit.org/attachment.cgi?id=311259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311259&action=review

> Source/WebCore/loader/DocumentThreadableLoader.cpp:270
> +    m_options.maxRedirectCount -= m_redirectCount;

Shouldn't m_redirectCount be reset to zero here?
Can you file a bugzilla about beefing up cached redirection tests?


More information about the webkit-reviews mailing list