[webkit-reviews] review requested: [Bug 172603] [WK2] Support onbeforeunload confirm panel in MiniBrowser : [Attachment 311267] Patch and unit tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 172603: [WK2] Support onbeforeunload confirm panel in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=172603

Attachment 311267: Patch and unit tests

https://bugs.webkit.org/attachment.cgi?id=311267&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 311267

  --> https://bugs.webkit.org/attachment.cgi?id=311267&action=review

Patch and unit tests

I deprecated the existing v5 WKPageRunBeforeUnloadConfirmPanelCallback and
introduced a new callback that takes a WKSecurityOriginRef. I chose to have the
new callback take a WKSecurityOriginRef as opposed to removing the WKFrameRef
argument and taking a WKFrameHandleRef that represents both the WKFrameRef and
WKSecurityOriginRef so as to make the arguments to the new callback more
closely match the arguments taken by other JavaScript dialog callbacks (e.g.
WKPageRunJavaScriptAlertCallback) and I was unclear about the future of the C
API now that we have the Modern WebKit2 API (Cocoa). Let me know if it is
preferred to have the new callback take a WKFrameHandleRef instead of both a
WKFrameRef and WKSecurityOriginRef.