[webkit-reviews] review granted: [Bug 172566] [WebIDL] Do a pass of cleanup in the bindings generator : [Attachment 311228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 25 10:35:50 PDT 2017


Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 172566: [WebIDL] Do a pass of cleanup in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=172566

Attachment 311228: Patch

https://bugs.webkit.org/attachment.cgi?id=311228&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 311228
  --> https://bugs.webkit.org/attachment.cgi?id=311228
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311228&action=review

> Source/WebCore/bindings/js/JSReadableStreamSourceCustom.cpp:42
> +    // FIXME: Why is it ok to ASSERT the argument count here?

I don't think it is OK :S


More information about the webkit-reviews mailing list