[webkit-reviews] review denied: [Bug 172592] Date should use historical data if it's available. : [Attachment 311227] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 172592: Date should use historical data if it's available.
https://bugs.webkit.org/show_bug.cgi?id=172592

Attachment 311227: Patch

https://bugs.webkit.org/attachment.cgi?id=311227&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 311227
  --> https://bugs.webkit.org/attachment.cgi?id=311227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311227&action=review

> Source/WTF/wtf/DateMath.cpp:-514
> -#if HAVE(TM_GMTOFF)
> -    double localToUTCTimeOffset = inputTimeType == LocalTime ?
calculateUTCOffset() : 0;
> -#else
> -    double localToUTCTimeOffset = calculateUTCOffset();
> -#endif
>      if (inputTimeType == LocalTime)
> -	   ms -= localToUTCTimeOffset;

Why remove the definition of localToUTCTimeOffset here?  The !HAVE(TM_GMTOFF)
case below still uses localToUTCTimeOffset.  Removing this now results in a
build error.

Also, the HAVE(TM_GMTOFF) case exhibits different behavior from the
!HAVE(TM_GMTOFF) case.	Is this no longer needed?  I don't see a correlation
between this and the purpose of this patch.  The fixup that you removed below
does not use localToUTCTimeOffset.  Can you clarify?