[webkit-reviews] review granted: [Bug 172558] REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test : [Attachment 311185] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 25 08:40:20 PDT 2017


Sam Weinig <sam at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 172558: REGRESSION (r216977): 4 leaks introduced in new
WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
https://bugs.webkit.org/show_bug.cgi?id=172558

Attachment 311185: Patch v2

https://bugs.webkit.org/attachment.cgi?id=311185&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 311185
  --> https://bugs.webkit.org/attachment.cgi?id=311185
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=311185&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:196
> +	       RetainPtr<WKWebViewConfiguration> configuration =
adoptNS([[WKWebViewConfiguration alloc] init]);

auto?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:199
> +	       RetainPtr<CookieUIDelegate> delegate =
adoptNS([[CookieUIDelegate alloc] init]);

auto?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:215
> +	       RetainPtr<WKWebViewConfiguration> configuration =
adoptNS([[WKWebViewConfiguration alloc] init]);

auto?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:218
> +	       RetainPtr<CookieUIDelegate> delegate =
adoptNS([[CookieUIDelegate alloc] init]);

auto?


More information about the webkit-reviews mailing list