[webkit-reviews] review granted: [Bug 172117] [css-grid] Fix behavior of positioned items without specific dimensions : [Attachment 310253] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 172117: [css-grid] Fix behavior of positioned items without specific
dimensions
https://bugs.webkit.org/show_bug.cgi?id=172117

Attachment 310253: Patch

https://bugs.webkit.org/attachment.cgi?id=310253&action=review




--- Comment #16 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 310253
  --> https://bugs.webkit.org/attachment.cgi?id=310253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310253&action=review

> Source/WebCore/ChangeLog:17
> +	   as it got confused because the container of the positioned grid
items

"was modified as it got confused" sounds really weird, please rephrase.

> Source/WebCore/rendering/RenderGrid.cpp:961
> +    child.setChildNeedsLayout(MarkOnlyThis);

I'm pretty happy to see the RenderBox code removed but I guess we can do better
than forcing a layout here. Add a FIXME here.