[webkit-reviews] review requested: [Bug 172553] [CMake] Wrap CODE_GENERATOR_PREPROCESSOR_EXECUTABLE on Windows hosts : [Attachment 311177] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 24 18:41:14 PDT 2017
Don Olmstead <don.olmstead at am.sony.com> has asked for review:
Bug 172553: [CMake] Wrap CODE_GENERATOR_PREPROCESSOR_EXECUTABLE on Windows
hosts
https://bugs.webkit.org/show_bug.cgi?id=172553
Attachment 311177: Patch
https://bugs.webkit.org/attachment.cgi?id=311177&action=review
--- Comment #6 from Don Olmstead <don.olmstead at am.sony.com> ---
Created attachment 311177
--> https://bugs.webkit.org/attachment.cgi?id=311177&action=review
Patch
Quotes the preprocessor path for everyone. CMAKE_CXX_COMPILER is the full path
so there's no reason to get its absolute path,
https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER.html.
More information about the webkit-reviews
mailing list