[webkit-reviews] review denied: [Bug 172507] [GTK] WEBKIT_[DISABLE|FORCE]_COMPOSITING_MODE does not work properly : [Attachment 311022] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 23 22:38:55 PDT 2017
Carlos Garcia Campos <cgarcia at igalia.com> has denied Gwang Yoon Hwang
<yoon at igalia.com>'s request for review:
Bug 172507: [GTK] WEBKIT_[DISABLE|FORCE]_COMPOSITING_MODE does not work
properly
https://bugs.webkit.org/show_bug.cgi?id=172507
Attachment 311022: Patch
https://bugs.webkit.org/attachment.cgi?id=311022&action=review
--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 311022
--> https://bugs.webkit.org/attachment.cgi?id=311022
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=311022&action=review
You are supposed to do WEBKIT_[DISABLE|FORCE]_COMPOSITING_MODE=1
> Source/WebKit2/UIProcess/gtk/HardwareAccelerationManager.cpp:57
> - if (disableCompositing && strcmp(disableCompositing, "0")) {
> + if (disableCompositing && !strcmp(disableCompositing, "0")) {
This is correct. if the variable is present and 0 we disable AC.
> Source/WebKit2/UIProcess/gtk/HardwareAccelerationManager.cpp:83
> - if (forceCompositing && strcmp(forceCompositing, "0"))
> + if (forceCompositing && !strcmp(forceCompositing, "0"))
Same here.
More information about the webkit-reviews
mailing list