[webkit-reviews] review granted: [Bug 172524] Resource Load Statistics: Change grandfathering default to one hour : [Attachment 311051] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 172524: Resource Load Statistics: Change grandfathering default to one hour
https://bugs.webkit.org/show_bug.cgi?id=172524

Attachment 311051: Patch

https://bugs.webkit.org/attachment.cgi?id=311051&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 311051
  --> https://bugs.webkit.org/attachment.cgi?id=311051
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311051&action=review

r=me

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152
> +   
WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600);

Weird that we can't use "grandfatheringTime" here, instead of a magic number.