[webkit-reviews] review denied: [Bug 171904] Web Inspector: Web Sockets: Unable to inspect a WebSocket that receives >50 messages per second : [Attachment 310948] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 171904: Web Inspector: Web Sockets: Unable to inspect a WebSocket that
receives >50 messages per second
https://bugs.webkit.org/show_bug.cgi?id=171904

Attachment 310948: Patch

https://bugs.webkit.org/attachment.cgi?id=310948&action=review




--- Comment #12 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 310948
  --> https://bugs.webkit.org/attachment.cgi?id=310948
Patch

(In reply to Joseph Pecoraro from comment #11)
> Comment on attachment 310948 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310948&action=review
> 
> > Source/WebInspectorUI/ChangeLog:16
> > +	     This patch makes sure treeElement gets re-attached if:
> > +	     - Its position (index) changes.
> > +	     - treeElement.status, which contains the go-to arrow and the close
resource icon, is not yet added to the DOM.
> 
> I understand re-attaching if the position changes. I do not understand why
> status has any affect on reattaching.
> 
> Why do we do the extra work if there is not a status icon?

Without this treeElement.status check, there was no go-to/close icon. I think I
finally figured it why.

Were these icons removed or never added?

    ResourceTreeElement#_updateStatus:
	treeElement.status = <div class="indeterminate-progress-spinner">

    ResourceTreeElement#_updateStatus:
	treeElement.status = ""

Turns out they were removed by ResourceTreeElement#_updateStatus.

WebSocketResourceTreeElement#_updateConnectionStatus is used in Resources tab,
but not Network tab.