[webkit-reviews] review granted: [Bug 172485] Snapshotting via -renderInContext: should do synchronous image decodes : [Attachment 311032] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 172485: Snapshotting via -renderInContext: should do synchronous image
decodes
https://bugs.webkit.org/show_bug.cgi?id=172485

Attachment 311032: Patch

https://bugs.webkit.org/attachment.cgi?id=311032&action=review




--- Comment #14 from Tim Horton <thorton at apple.com> ---
Comment on attachment 311032
  --> https://bugs.webkit.org/attachment.cgi?id=311032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311032&action=review

> Source/WebCore/platform/graphics/mac/WebLayer.h:33
> +    BOOL m_isRenderingInContext;

Shouldn't have an m prefix.

> Source/WebCore/platform/graphics/mac/WebLayer.h:35
> + at property (nonatomic) BOOL _isRenderingInContext;

Why is this readwrite? Why does this have a leading underscore? This is an
internal class. Should check with the SPI guidelines but I don't think the _ is
required.

> Source/WebCore/platform/ios/wak/WAKWindow.h:136
> +- (void)setIsInSnapshottingPaint:(BOOL)isInSnapshottingPaint;
> +- (BOOL)isInSnapshottingPaint;

Why is this not a property :P

> Source/WebKit/mac/WebView/WebViewPrivate.h:-771
> --
(void)_setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:(BOOL)flag;
> -- (BOOL)_includesFlattenedCompositingLayersWhenDrawingToBitmap;

Are you sure it's OK to remove these?