[webkit-reviews] review granted: [Bug 172495] Zoom in/out is slow in Safari with large PDFs : [Attachment 311035] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 172495: Zoom in/out is slow in Safari with large PDFs
https://bugs.webkit.org/show_bug.cgi?id=172495

Attachment 311035: Patch

https://bugs.webkit.org/attachment.cgi?id=311035&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 311035
  --> https://bugs.webkit.org/attachment.cgi?id=311035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311035&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1160
> +    m_firstPageHeight = static_cast<unsigned>(CGCeiling([[m_pdfDocument
pageAtIndex:0] boundsForBox:kPDFDisplayBoxCropBox].size.height));

Do we always have a page 0?